remove unreachable error code E0313 #106580
Merged
+3 −46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
| (rustbot has picked a reviewer for you, use r? to override) |
rustbot added A-testsuite Collaborator
| Some changes occurred in diagnostic error codes |
Contributor Author
| r? rust-lang/compiler I believe @petrochenkov wants to take a break from reviewing. |
Member
| Thanks @Ezrashaw r? @compiler-errors @bors r+ rollup |
Collaborator
bors added S-waiting-on-bors JohnTitor pushed a commit to JohnTitor/rust that referenced this pull request Jan 8, 2023
…errors remove unreachable error code `E0313` Fixes rust-lang#103742 Makes rust-lang#103433 redundant Implements removal of `E0313`. I agree with the linked issue that this error code is unreachable but if someone could confirm that would be great, are crater runs done for this sort of thing? Also removed a redundant `// ignore-tidy-filelength` that I found while reading code. cc `@GuillaumeGomez` rust-lang#61137
This was referenced Jan 8, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 8, 2023
Rollup of 8 pull requests Successful merges: - rust-lang#103104 (Stabilize `main_separator_str`) - rust-lang#106410 (Suggest `mut self: &mut Self` for `?Sized` impls) - rust-lang#106457 (Adjust comments about pre-push.sh hook) - rust-lang#106546 (jsondoclint: Check local items in `paths` are also in `index`.) - rust-lang#106557 (Add some UI tests and reword error-code docs) - rust-lang#106562 (Clarify examples for `VecDeque::get/get_mut`) - rust-lang#106580 (remove unreachable error code `E0313`) - rust-lang#106581 (Do not emit wrong E0308 suggestion for closure mismatch) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
100 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #103742
Makes #103433 redundant
Implements removal of
E0313. I agree with the linked issue that this error code is unreachable but if someone could confirm that would be great, are crater runs done for this sort of thing?Also removed a redundant
// ignore-tidy-filelengththat I found while reading code.cc @GuillaumeGomez #61137