Mention "signature" rather than "fn pointer" when impl/trait methods are incompatible #106131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| r? @davidtwco (rustbot has picked a reviewer for you, use r? to override) |
rustbot added S-waiting-on-review 
This comment was marked as resolved.
This comment was marked as resolved.
compiler-errors force-pushed the not-ptrs branch from 045af40 to 117b8b4 Compare 
davidtwco approved these changes Jan 7, 2023
| @bors r+ |
| 📌 Commit 117b8b44b232bc44d3c3a69e1e679a6aa086f910 has been approved by It is now in the queue for this repository. |
bors added S-waiting-on-bors 
| ☔ The latest upstream changes (presumably #106573) made this pull request unmergeable. Please resolve the merge conflicts. |
bors added S-waiting-on-author compiler-errors force-pushed the not-ptrs branch from 117b8b4 to 482587e Compare rustbot added the A-translation |
cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki |
compiler-errors force-pushed the not-ptrs branch from 482587e to 49f849a Compare 
| @bors r=davidtwco |
bors added S-waiting-on-bors compiler-errors added a commit to compiler-errors/rust that referenced this pull request Jan 9, 2023
Mention "signature" rather than "fn pointer" when impl/trait methods are incompatible Fixes rust-lang#80929 Fixes rust-lang#67296
This was referenced Jan 9, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 9, 2023
…mpiler-errors Rollup of 8 pull requests Successful merges: - rust-lang#104163 (Don't derive Debug for `OnceWith` & `RepeatWith`) - rust-lang#106131 (Mention "signature" rather than "fn pointer" when impl/trait methods are incompatible) - rust-lang#106363 (Structured suggestion for `&mut dyn Iterator` when possible) - rust-lang#106497 (Suggest using clone when we have &T and T implemented Clone) - rust-lang#106584 (Document that `Vec::from_raw_parts[_in]` must be given a pointer from the correct allocator.) - rust-lang#106600 (Suppress type errors that come from private fields) - rust-lang#106602 (Add goml scripts to tidy checks) - rust-lang#106606 (Do not emit structured suggestion for turbofish with wrong span) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #80929
Fixes #67296