Skip to content

Rollup of 7 pull requests #105703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Dec 14, 2022
Merged

Rollup of 7 pull requests #105703

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
27011b4
Use more LFS functions.
Dec 6, 2022
6085d33
fix transmutes between pointers in different address spaces
erikdesjardins Dec 11, 2022
3465d5f
explain mem::forget(env_lock) in fork/exec
RalfJung Dec 12, 2022
675fa0b
🚨 fix unsoundness in bootstrap cache code
compiler-errors Dec 12, 2022
19e7dbd
Improve rustdoc markdown variable naming
GuillaumeGomez Dec 13, 2022
6844b17
Add a test for #92481
albertlarsan68 Dec 12, 2022
f7db4f0
Bless test
albertlarsan68 Dec 14, 2022
060e033
Remove fee1-dead from reviewers
fee1-dead Dec 14, 2022
35ff2cf
Rollup merge of #105399 - mikebenfield:lfs, r=thomcc
matthiaskrgr Dec 14, 2022
ba71a63
Rollup merge of #105578 - erikdesjardins:addrspacecast, r=bjorn3
matthiaskrgr Dec 14, 2022
6d3a93c
Rollup merge of #105598 - RalfJung:more-comments, r=the8472
matthiaskrgr Dec 14, 2022
0e861cc
Rollup merge of #105624 - compiler-errors:cache-unsound, r=jyn514
matthiaskrgr Dec 14, 2022
e2c9823
Rollup merge of #105630 - albertlarsan68:test-92481, r=TaKO8Ki
matthiaskrgr Dec 14, 2022
37bf2bc
Rollup merge of #105684 - GuillaumeGomez:improve-rustdoc-var-name, r=…
matthiaskrgr Dec 14, 2022
3069bc0
Rollup merge of #105697 - fee1-dead-contrib:rm-fee1-dead, r=Mark-Simu…
matthiaskrgr Dec 14, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
🚨 fix unsoundness in bootstrap cache code
  • Loading branch information
@compiler-errors
compiler-errors committed Dec 12, 2022
commit 675fa0b3dd5fe14b43ad5b7862f4528df7322468
8 changes: 4 additions & 4 deletions src/bootstrap/cache.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,16 +89,16 @@ impl<T: Internable + Hash> Hash for Interned<T> {

impl<T: Internable + Deref> Deref for Interned<T> {
type Target = T::Target;
fn deref(&self) -> &'static Self::Target {
fn deref(&self) -> &Self::Target {
let l = T::intern_cache().lock().unwrap();
unsafe { mem::transmute::<&Self::Target, &'static Self::Target>(l.get(*self)) }
unsafe { mem::transmute::<&Self::Target, &Self::Target>(l.get(*self)) }
}
}

impl<T: Internable + AsRef<U>, U: ?Sized> AsRef<U> for Interned<T> {
fn as_ref(&self) -> &'static U {
fn as_ref(&self) -> &U {
let l = T::intern_cache().lock().unwrap();
unsafe { mem::transmute::<&U, &'static U>(l.get(*self).as_ref()) }
unsafe { mem::transmute::<&U, &U>(l.get(*self).as_ref()) }
}
}

Expand Down