interpret: clobber return place when calling function #105207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rustbot added S-waiting-on-review 
| Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri |
RalfJung force-pushed the interpret-clobber-return branch from 4c61d9a to 51ac2af Compare 
| @bors r+ rollup |
bors added S-waiting-on-bors matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 5, 2022
… r=oli-obk interpret: clobber return place when calling function Makes sure the callee cannot observe the previous contents of the return place, and the caller cannot read any of the old return place contents even if the function unwinds. I don't think we can test for this though, that would require some strange hand-written MIR. r? `@oli-obk`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 5, 2022
… r=oli-obk interpret: clobber return place when calling function Makes sure the callee cannot observe the previous contents of the return place, and the caller cannot read any of the old return place contents even if the function unwinds. I don't think we can test for this though, that would require some strange hand-written MIR. r? ``@oli-obk``
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 5, 2022
… r=oli-obk interpret: clobber return place when calling function Makes sure the callee cannot observe the previous contents of the return place, and the caller cannot read any of the old return place contents even if the function unwinds. I don't think we can test for this though, that would require some strange hand-written MIR. r? ```@oli-obk```
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 5, 2022
… r=oli-obk interpret: clobber return place when calling function Makes sure the callee cannot observe the previous contents of the return place, and the caller cannot read any of the old return place contents even if the function unwinds. I don't think we can test for this though, that would require some strange hand-written MIR. r? ````@oli-obk````
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 6, 2022
Rollup of 10 pull requests Successful merges: - rust-lang#104967 (Fix UI issues with Rustdoc scrape-examples feature.) - rust-lang#105207 (interpret: clobber return place when calling function) - rust-lang#105246 (Fix --pass in compiletest) - rust-lang#105256 (Add small comment explaining what `method-margins.goml` test is about) - rust-lang#105289 (Fix dupe word typos) - rust-lang#105309 (rustdoc: remove no-op mobile CSS `.sidebar { margin: 0; padding: 0 }`) - rust-lang#105313 (Update books) - rust-lang#105315 (Normalize inherent associated types after substitution) - rust-lang#105324 (Point at GAT `where` clause when an obligation is unsatisfied) - rust-lang#105338 (Tweak "the following other types implement trait") Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Makes sure the callee cannot observe the previous contents of the return place, and the caller cannot read any of the old return place contents even if the function unwinds.
I don't think we can test for this though, that would require some strange hand-written MIR.
r? @oli-obk