Remove RunCompiler and related things. #102759
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rustbot added T-compiler 
| Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt The Miri subtree was changed cc @rust-lang/miri Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
rust-highfive added the S-waiting-on-review 
I tried removing two methods in `RunCompiler` that were marked as being used by RLS. Tugging on this loose thread led to lots of code removal, including: - `RunCompiler` - `DiagnosticOutput` - `FileLoader` and `RealFileLoader` - Three fields in `Config` Note also that the "Ideally, ..." comment in `SourceMap::load_binary_file` is removed because it's no longer relevant.
nnethercote force-pushed the rm-RunCompiler branch from b39a8a1 to 4fefe40 Compare 
bjorn3 reviewed Oct 7, 2022
| emitter: Option<Box<dyn Write + Send>>, | ||
| make_codegen_backend: Option< | ||
| Box<dyn FnOnce(&config::Options) -> Box<dyn CodegenBackend> + Send>, | ||
| >, |
There was a problem hiding this comment.
I still have a use case for both file_loader (using it for hooking rust-analyzers VFS into rustc at some point for running rustc without having to save) and make_codegen_backend (setting the codegen backend from a custom driver where the custom codegen backend has arbitrary data. used by the hotswapping branch of cg_clif)
There was a problem hiding this comment.
Argh. This is frustrating when there is no way to tell if an interface like this is being used.
| I filed #102992 to just remove the emitter. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I tried removing two methods in
RunCompilerthat were marked as being used by RLS. Tugging on this loose thread led to lots of code removal, including:RunCompilerDiagnosticOutputFileLoaderandRealFileLoaderConfigNote also that the "Ideally, ..." comment in
SourceMap::load_binary_fileis removed because it's no longer relevant.r? @bjorn3