Improve -Zmeta-stats some more #102041
Merged
Improve -Zmeta-stats some more #102041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rustbot added the T-compiler 
rust-highfive added the S-waiting-on-review 
| Best reviewed one commit at a time. The first commit is stolen from #101014, and we should probably let that PR merge before this one. |
bjorn3 approved these changes Sep 20, 2022
| r=me once #101014 lands. |
| I forgot to show the before: and after |
nnethercote force-pushed the improve-meta-stats branch from 68f1c74 to fcbc70c Compare 
| 📌 Commit fcbc70cdb5d25d9f653edd35e7950acc8a869e81 has been approved by It is now in the queue for this repository. |
bors added S-waiting-on-bors | @bors rollup=always |
It's now much more like the `-Zhir-stats` output. - Each line is preceded with `meta-stats`, which makes the provenance clearer and allows filtering of the output. - Sections are now sorted in reverse order of size. - Column headings avoid the need to repeat the word "bytes" on every line. - Long numbers now have `_` separators for easier reading. - Consistent use of '-' within section labels, rather than a mix of '-', '_', and ' '. The code itself is shorter and easier to read thanks to: - the `stat` macro, which encapsulates each section's encoding, avoids some boilerplate, and removes the need for some low-value comments; - the `stats` vector, which replaces dozens of local variables.
nnethercote force-pushed the improve-meta-stats branch from fcbc70c to a7b35b5 Compare | @bors r=bjorn3 |
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 21, 2022
…bjorn3 Improve `-Zmeta-stats` some more A follow-up to rust-lang#97384. r? `@bjorn3`
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 21, 2022
…bjorn3 Improve `-Zmeta-stats` some more A follow-up to rust-lang#97384. r? ``@bjorn3``
This was referenced Sep 21, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 21, 2022
Rollup of 7 pull requests Successful merges: - rust-lang#89891 (`alloc`: add unstable cfg features `no_rc` and `no_sync`) - rust-lang#101995 (Add another example for `uN::carrying_mul`) - rust-lang#102031 (Adding ignore fuchsia tests for Backtrace, ErrorKind cases) - rust-lang#102041 (Improve `-Zmeta-stats` some more) - rust-lang#102045 (fix ConstProp handling of written_only_inside_own_block_locals) - rust-lang#102058 (Clarify Path::extension() semantics in docs abstract) - rust-lang#102059 (Use rebind instead of dummy binder in `SameTypeModuloInfer` relation) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
A follow-up to #97384.
r? @bjorn3