A SubstitutionPart is not considered a deletion if it replaces nothing with nothing #101700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rustbot added the T-compiler 
Contributor
| r? @lcnr (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive added the S-waiting-on-review 
compiler-errors commented Sep 11, 2022
Contributor
| r? compiler |
davidtwco approved these changes Sep 12, 2022
Member
| @bors r+ |
Collaborator
Collaborator
| 🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened. |
bors added S-waiting-on-bors GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 12, 2022
…avidtwco A `SubstitutionPart` is not considered a deletion if it replaces nothing with nothing Fixes rust-lang#101689
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 12, 2022
…avidtwco A `SubstitutionPart` is not considered a deletion if it replaces nothing with nothing Fixes rust-lang#101689
Member Author
| @bors r- (#101733 (comment)) |
bors added S-waiting-on-author 
compiler-errors force-pushed the deletion-span branch from 3bf33c3 to c0c6042 Compare compiler-errors added the S-waiting-on-review compiler-errors force-pushed the deletion-span branch from c0c6042 to cd962e6 Compare davidtwco approved these changes Sep 13, 2022
Member
| @bors r+ |
Collaborator
bors added S-waiting-on-bors 
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 13, 2022
…avidtwco A `SubstitutionPart` is not considered a deletion if it replaces nothing with nothing Fixes rust-lang#101689
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 13, 2022
Rollup of 5 pull requests Successful merges: - rust-lang#101602 (Streamline `AttrAnnotatedTokenStream`) - rust-lang#101690 (Avoid `Iterator::last`) - rust-lang#101700 (A `SubstitutionPart` is not considered a deletion if it replaces nothing with nothing) - rust-lang#101745 (Fix typo in concat_bytes documentation) - rust-lang#101748 (rustdoc: remove redundant CSS `#source-sidebar, #sidebar-toggle`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #101689