rustdoc: remove unused CSS #implementations-list > h3 > span.in-band #101554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rustbot added the T-rustdoc 
| Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
| r? @jsha (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive added the S-waiting-on-review 
notriddle force-pushed the notriddle/implemenation-list-h3-span-in-band branch from 4c8449c to 6d2935d Compare 
This was added in 51f26ac to help with the display of an `<h3>` tag that has a `<span class='in-band'>` inside. The way implementation lists were rendered was changed in 34bd2b8 to have `<code class='in-band'>`, making this CSS unused. Then it was turned into a `<div>` in 9077d54 without issue. Finally, the header itself acquired the `in-band` class in 76a3b60.
| @bors r+ rollup |
bors added S-waiting-on-bors 
GuillaumeGomez approved these changes Sep 8, 2022
sanxiyn added a commit to sanxiyn/rust that referenced this pull request Sep 8, 2022
…list-h3-span-in-band, r=Dylan-DPC rustdoc: remove unused CSS `#implementations-list > h3 > span.in-band` This was added in 51f26ac to help with the display of an `<h3>` tag that has a `<span class='in-band'>` inside. The way implementation lists were rendered was changed in 34bd2b8 to have `<code class='in-band'>`, making this CSS unused. Then it was turned into a `<div>` in 9077d54 without issue. Finally, the header itself acquired the `in-band` class in 76a3b60.
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 8, 2022
…mpiler-errors Rollup of 7 pull requests Successful merges: - rust-lang#101423 (Fix hermit warnings) - rust-lang#101499 (Introduce lowering_arena to avoid creating AST nodes on the fly) - rust-lang#101530 (llvm-wrapper: adapt for LLVM API changes) - rust-lang#101554 (rustdoc: remove unused CSS `#implementations-list > h3 > span.in-band`) - rust-lang#101580 (rustdoc: remove unused CSS `div.impl-items > div`) - rust-lang#101584 (rustdoc: remove no-op CSS `#settings-menu { padding: 0 }`) - rust-lang#101587 (Make `Debug` impl for `Term` useful) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This was added in 51f26ac to help with the display of an
<h3>tag that has a<span class='in-band'>inside.The way implementation lists were rendered was changed in 34bd2b8 to have
<code class='in-band'>, making this CSS unused.Then it was turned into a
<div>in 9077d54 without issue.Finally, the header itself acquired the
in-bandclass in 76a3b60.