Skip to content

Add AsFd implementations for stdio types on WASI. #100892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2022
Merged

Add AsFd implementations for stdio types on WASI. #100892

merged 1 commit into from
Aug 31, 2022

Conversation

sunfishcode
Copy link
Member

This mirrors the implementations on Unix platforms, and also mirrors the
existing AsRawFd impls.
@sunfishcode
Add AsFd implementations for stdio types on WASI.
2efe6b0 
This mirrors the implementations on Unix platforms, and also mirrors the existing `AsRawFd` impls.
@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Aug 22, 2022
@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 22, 2022
@joshtriplett
Copy link
Member

@bors r+
@bors
Copy link
Collaborator

bors commented Aug 23, 2022

📌 Commit 2efe6b0 has been approved by joshtriplett

It is now in the queue for this repository.
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 23, 2022
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Aug 30, 2022
@JohnTitor
Rollup merge of rust-lang#100892 - sunfishcode:wasi-stdio-asfd, r=jos…
756daba 
…htriplett Add `AsFd` implementations for stdio types on WASI. This mirrors the implementations on Unix platforms, and also mirrors the existing `AsRawFd` impls.
@JohnTitor JohnTitor mentioned this pull request Aug 30, 2022
Closed
@JohnTitor JohnTitor mentioned this pull request Aug 30, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 31, 2022
@bors
Auto merge of rust-lang#101220 - JohnTitor:rollup-ov7upr7, r=JohnTitor
7f442f8 
Rollup of 10 pull requests Successful merges: - rust-lang#100804 (Fix search results color on hover for ayu theme) - rust-lang#100892 (Add `AsFd` implementations for stdio types on WASI.) - rust-lang#100927 (Adding new Fuchsia rustup docs... reworking walkthrough) - rust-lang#101088 (Set DebuginfoKind::Pdb in msvc_base) - rust-lang#101159 (add tracking issue number to const_slice_split_at_not_mut) - rust-lang#101192 (Remove path string) - rust-lang#101193 (Avoid zeroing large stack buffers in stdio on Windows) - rust-lang#101197 (:arrow_up: rust-analyzer) - rust-lang#101200 (Add test for issue rust-lang#85872) - rust-lang#101219 (Update books) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
@bors bors merged commit 3a764e9 into rust-lang:master Aug 31, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 31, 2022
@sunfishcode sunfishcode mentioned this pull request Sep 13, 2022
Merged
bors pushed a commit to rust-lang-ci/rust that referenced this pull request Oct 4, 2022
@sunfishcode
Add AsFd implementations for stdio lock types on WASI.
ed812c7 
This mirrors the implementations on Unix platforms, and also mirrors the existing `AsRawFd` impls. This is similar to rust-lang#100892, but is for the `*Lock` types.
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 4, 2022
@bors
Auto merge of rust-lang#101768 - sunfishcode:sunfishcode/wasi-stdio-l…
d4846f9 
…ock-asfd, r=joshtriplett Add `AsFd` implementations for stdio lock types on WASI. This mirrors the implementations on Unix platforms, and also mirrors the existing `AsRawFd` impls. This is similar to rust-lang#100892, but is for the `*Lock` types.
@joshtriplett joshtriplett mentioned this pull request Oct 9, 2022
Merged
joshtriplett added a commit to joshtriplett/rust that referenced this pull request Oct 9, 2022
@joshtriplett
impl AsFd for io::{Stdin, Stdout, Stderr}, not the sys versions
88bb4e4 
rust-lang#100892 implemented AsFd for the sys versions, rather than for the public types. Change the implementations to apply to the public types.
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Oct 11, 2022
@Dylan-DPC
Rollup merge of rust-lang#102847 - joshtriplett:bugfix-impl-fd-traits…
6e3f2e6 
…-for-io-types, r=m-ou-se impl AsFd and AsRawFd for io::{Stdin, Stdout, Stderr}, not the sys versions rust-lang#100892 implemented AsFd for the sys versions, rather than for the public types. Change the implementations to apply to the public types.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 11, 2022
@matthiaskrgr
Rollup merge of rust-lang#102847 - joshtriplett:bugfix-impl-fd-traits…
2da609a 
…-for-io-types, r=m-ou-se impl AsFd and AsRawFd for io::{Stdin, Stdout, Stderr}, not the sys versions rust-lang#100892 implemented AsFd for the sys versions, rather than for the public types. Change the implementations to apply to the public types.
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Oct 12, 2022
@Dylan-DPC
Rollup merge of rust-lang#102847 - joshtriplett:bugfix-impl-fd-traits…
a51f145 
…-for-io-types, r=m-ou-se impl AsFd and AsRawFd for io::{Stdin, Stdout, Stderr}, not the sys versions rust-lang#100892 implemented AsFd for the sys versions, rather than for the public types. Change the implementations to apply to the public types.
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Oct 14, 2022
@Dylan-DPC
Rollup merge of rust-lang#102847 - joshtriplett:bugfix-impl-fd-traits…
854bb2b 
…-for-io-types, r=m-ou-se impl AsFd and AsRawFd for io::{Stdin, Stdout, Stderr}, not the sys versions rust-lang#100892 implemented AsFd for the sys versions, rather than for the public types. Change the implementations to apply to the public types.
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Oct 14, 2022
@Dylan-DPC
Rollup merge of rust-lang#102847 - joshtriplett:bugfix-impl-fd-traits…
b03bece 
…-for-io-types, r=m-ou-se impl AsFd and AsRawFd for io::{Stdin, Stdout, Stderr}, not the sys versions rust-lang#100892 implemented AsFd for the sys versions, rather than for the public types. Change the implementations to apply to the public types.
lyming2007 pushed a commit to lyming2007/rust that referenced this pull request Oct 21, 2022
@joshtriplett
impl AsFd for io::{Stdin, Stdout, Stderr}, not the sys versions
2126365 
rust-lang#100892 implemented AsFd for the sys versions, rather than for the public types. Change the implementations to apply to the public types.
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
@bors
Auto merge of rust-lang#101768 - sunfishcode:sunfishcode/wasi-stdio-l…
0c5a645 
…ock-asfd, r=joshtriplett Add `AsFd` implementations for stdio lock types on WASI. This mirrors the implementations on Unix platforms, and also mirrors the existing `AsRawFd` impls. This is similar to rust-lang#100892, but is for the `*Lock` types.
thomcc pushed a commit to tcdi/postgrestd that referenced this pull request Feb 10, 2023
@joshtriplett
impl AsFd for io::{Stdin, Stdout, Stderr}, not the sys versions
36f5c4c 
rust-lang/rust#100892 implemented AsFd for the sys versions, rather than for the public types. Change the implementations to apply to the public types.
thomcc pushed a commit to tcdi/postgrestd that referenced this pull request Feb 10, 2023
@Dylan-DPC
Rollup merge of #102847 - joshtriplett:bugfix-impl-fd-traits-for-io-t…
4691f0c 
…ypes, r=m-ou-se impl AsFd and AsRawFd for io::{Stdin, Stdout, Stderr}, not the sys versions rust-lang/rust#100892 implemented AsFd for the sys versions, rather than for the public types. Change the implementations to apply to the public types.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

6 participants

@sunfishcode @rust-highfive @joshtriplett @bors @Mark-Simulacrum @rustbot