- Notifications
You must be signed in to change notification settings - Fork 13.9k
Closed
Labels
C-bugCategory: This is a bug.Category: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-releaseRelevant to the release subteam, which will review and decide on the PR/issue.Relevant to the release subteam, which will review and decide on the PR/issue.
Description
Code
Following https://rustc-dev-guide.rust-lang.org/getting-started.html
git clone --recurse -b 1.48.0 https://github.com/rust-lang/rust.git cd rust ./x.py setup # Choose "d) Install Rust from source" ./x.py check I expected to see this happen: works
Instead, this happened:
$ cat config.toml # Includes one of the default files in src/bootstrap/defaults profile = "maintainer" $ ./x.py check Updating only changed submodules Submodules updated in 0.06 seconds Finished dev [unoptimized + debuginfo] target(s) in 0.13s thread 'main' panicked at 'fs::read_to_string(file) failed with No such file or directory (os error 2) ("`include` config not found")', src/bootstrap/config.rs:563:28 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace failed to run: /usr/local/google/home/maruel/src-oth/rust/build/bootstrap/debug/bootstrap check Build completed unsuccessfully in 0:00:00 $ ls src/bootstrap/defaults config.toml.codegen config.toml.compiler config.toml.library config.toml.user README.md It's because src/bootstrap/defaults/ doesn't contain config.toml.maintainer
Version it worked on
1.47.0 doesn't have x.py setup.
Version with regression
1.48.0
Metadata
Metadata
Assignees
Labels
C-bugCategory: This is a bug.Category: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-releaseRelevant to the release subteam, which will review and decide on the PR/issue.Relevant to the release subteam, which will review and decide on the PR/issue.