Typo and trivial tidying #51
Conversation
The rustbook link redirects, so I put the new one in. Also put the build command in the section that promises it.
| Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
There was a problem hiding this comment.
@steveklabnik do you know if your rustbook repo still builds? If not this may want to actually link to the in-tree copy as it's what's actually building the documentation in-tree at least. (not a great situation to be in!)
There was a problem hiding this comment.
The CI badge on the repo says its build is currently failing...
There was a problem hiding this comment.
My repo is just a copy of the in-tree code. I thought I had rust-ci letting me know if it was broke, but maybe I don't.
There was a problem hiding this comment.
Ah ok, perhaps this could link to the in-tree copy then? Other than that looks good to me!
| Oh hey sorry! I didn't realize this was open against this repo :( |
| Don't worry, this PR's goal got accomplished even better than I expected -- it drew enough attention to the repo to point out that it was redundant :) |
| :) |
5 participants
The rustbook link redirects, so I put the new one in.
Also put the build command in the section that promises it.