Skip to content

Document policy for adding ecosystem/integration test jobs/components to rust-lang/rust CI #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2025
Merged

Document policy for adding ecosystem/integration test jobs/components to rust-lang/rust CI #813

merged 1 commit into from
Apr 16, 2025

Conversation

@jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented Feb 28, 2025 •
edited by rustbot
Loading

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 28, 2025
@jieyouxu jieyouxu added T-compiler Team: Compiler T-infra Team: Infrastructure labels Feb 28, 2025
@jieyouxu
Copy link
Member Author

jieyouxu commented Mar 3, 2025 •
edited
Loading

Blocked on opening an MCP for this first.
@rustbot blocked

EDIT: rust-lang/compiler-team#845
@rustbot rustbot added S-blocked Status: Blocked on something else such as a PR in another repository. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 3, 2025
@jieyouxu jieyouxu force-pushed the mcp-for-ecosystem-testing branch 2 times, most recently from 154c3e5 to e771902 Compare March 20, 2025 14:36
@jieyouxu jieyouxu changed the title Require compiler MCP for adding new Ecosystem Testing CI job [WIP] Document policy for adding custom test jobs/components to rust-lang/rust CI Mar 20, 2025
@jieyouxu jieyouxu force-pushed the mcp-for-ecosystem-testing branch from e771902 to 625effb Compare March 20, 2025 14:42
This was referenced Mar 20, 2025
Closed
Open
jieyouxu
jieyouxu commented Mar 20, 2025
View reviewed changes
jieyouxu
jieyouxu commented Mar 21, 2025
View reviewed changes
@jieyouxu jieyouxu force-pushed the mcp-for-ecosystem-testing branch from 625effb to 3c0264c Compare March 21, 2025 06:24
Kobzol
Kobzol reviewed Mar 21, 2025
View reviewed changes
Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks. The diagram kind of shows how desynchronized are the decision processes between t-compiler and t-libs (and other teams) currently :) Left some comments.
jieyouxu
jieyouxu commented Mar 21, 2025
View reviewed changes
jieyouxu
jieyouxu commented Mar 21, 2025
View reviewed changes
jieyouxu
jieyouxu commented Mar 21, 2025
View reviewed changes
@jieyouxu jieyouxu mentioned this pull request Mar 21, 2025
Merged
davidtwco
davidtwco approved these changes Mar 24, 2025
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits, but this looks great.
@jieyouxu
Copy link
Member Author

jieyouxu commented Mar 26, 2025

Changes since last review:

  • Hard-wrapped to 100 columns.
  • Changed terminology to use "ecosystem/integration test jobs/components" instead.
  • Spelled out the process (instead of just having the diagram).
  • Adjusted process (text and diagram) to ask infra about capacity first (discussed in #t-infra > Policy for adding custom test jobs/components to r-l/r CI).
  • Dropped mentions about ping groups because only team members + certain WG members can use triagebot ping group anyway.
  • Adjusted scope wording.
jieyouxu
jieyouxu commented Mar 26, 2025
View reviewed changes
@ZuseZ4 ZuseZ4 mentioned this pull request Mar 27, 2025
Closed
3 tasks
jieyouxu
jieyouxu commented Mar 27, 2025
View reviewed changes
@jieyouxu
Copy link
Member Author

jieyouxu commented Mar 28, 2025

Changes since last push:
@jieyouxu
Copy link
Member Author

jieyouxu commented Mar 28, 2025

Changes since last push (take 2):

  • Looking at Enable autodiff testcases in CI compiler-team#855 again, I converted the policy template into a markdown block, because when this template (previously) get rendered into a webpage, copy-pasting completely loses the markdown formatting. Instead, present the policy template as a markdown codeblock (raw markdown annotations) so pasting it into e.g. an MCP will become properly formatted.
@jieyouxu jieyouxu removed the S-blocked Status: Blocked on something else such as a PR in another repository. label Apr 8, 2025
@jieyouxu jieyouxu added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 8, 2025
@jieyouxu
Copy link
Member Author

jieyouxu commented Apr 8, 2025

The MCP was accepted so this should be ready for another review pass (but not merge, I want to fix the filename before merge).
Kobzol
Kobzol approved these changes Apr 8, 2025
View reviewed changes
@jieyouxu
Copy link
Member Author

jieyouxu commented Apr 16, 2025

I'll fix the numbering and the file link renames
@jieyouxu jieyouxu force-pushed the mcp-for-ecosystem-testing branch from 14e113c to 5c296f2 Compare April 16, 2025 14:37
@jieyouxu jieyouxu changed the title [WIP] Document policy for adding custom test jobs/components to rust-lang/rust CI Document policy for adding ecosystem/integration test jobs/components to rust-lang/rust CI Apr 16, 2025
@jieyouxu
Copy link
Member Author

jieyouxu commented Apr 16, 2025

File is renamed with links fixed
@jieyouxu jieyouxu merged commit 8d63396 into rust-lang:master Apr 16, 2025
1 check passed
@jieyouxu jieyouxu deleted the mcp-for-ecosystem-testing branch April 16, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Team: Compiler T-infra Team: Infrastructure

4 participants

@jieyouxu @davidtwco @Kobzol @rustbot