deprecate invalid_ref lint #4368
Conversation
| The clippy lint is also almost entirely subsumed by the new rustc lint added in that PR, so maybe it should just be removed? ("Almost" because I didn't bother warning for direct uses of the intrinsics. They are perma-unstable and scheduled for removal, after all.) |
| Windows CI failure doesn't look like I caused it? |
| @Manishearth could you take a look? This blocks a new rustc lint that would be really nice to have in the beta. |
Yes, just move it to the list of deprecated lints |
| @Manishearth done. |
RalfJung changed the title 
| @bors r+ |
| 📌 Commit 2dcce60 has been approved by |
deprecate invalid_ref lint This fixes the `invalid_ref` lint test to no longer fail when rust-lang/rust#63346 lands. I also fixed the lint itself, because its wording made no sense: there is no "reference to zeroed/uninitialized memory" here. changelog: none
| Also needs |
| 💔 Test failed - checks-travis |
| @RalfJung: 🔑 Insufficient privileges: Not in reviewers |
| @bors r+ |
| 📌 Commit 40fea7a has been approved by |
deprecate invalid_ref lint This fixes the `invalid_ref` lint test to no longer fail when rust-lang/rust#63346 lands. I also fixed the lint itself, because its wording made no sense: there is no "reference to zeroed/uninitialized memory" here. changelog: none
| @bors delegate+ |
| ✌️ @RalfJung can now approve this pull request |
| ☀️ Test successful - checks-travis, status-appveyor |
5 participants
This fixes the
invalid_reflint test to no longer fail when rust-lang/rust#63346 lands. I also fixed the lint itself, because its wording made no sense: there is no "reference to zeroed/uninitialized memory" here.changelog: none