Remove profile from Cargo.toml

[Kobzol]

To avoid warnings in rust-lang/rust.

This subtree sync started causing warnings in Rust builds (rust-lang/rust#145777) because of the profile section in Clippy's Cargo.toml file. This profile section was added in #13408 last year, and since it also caused issues then, it was later reverted. However, this change recently reappeared in this commit, so it is again causing issues for rust-lang/rust.

This PR removes the profile section again.

changelog:

Caution

Concerns (1 active)

• Large performance issue in lintcheck

Managed by @rustbot—see help for details.

[rustbot]

r? @Alexendoo

rustbot has assigned @Alexendoo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[samueltardieu]

I am a bit confused when you say it reappeared on June 26, since this fragment is also present in Clippy's Cargo.toml earlier in June (for example at this point on June 5).

Maybe it is just a sync issue, and this profile should be present in Clippy repository but removed from the compiler one, and this difference preserved during the merged process. I could write a test that would check for the presence/absence of profile fragments depending on the repository we're on to ensure that the sync process preserves this.

@flip1995 What do you think about this? Should I write the test, and should we remove the profile section on the compiler side only?

r? flip1995
@rustbot concern Large performance issue in lintcheck

[samueltardieu]

Compiler-side PR: rust-lang/rust#145781

[Kobzol]

https://github.com/rust-lang/rust-clippy/blob/9f86a576e30d85912602f67b605ff3a33a50401f/Cargo.toml it wasn't there at the end of May though 😅

Maybe it would be better if Clippy configured this through its .cargo/config.toml file instead through Cargo.toml? That shouldn't be applied when we build from rust-lang/rust, I think, and it is already used for other things (

rust-clippy/.cargo/config.toml

Line 19 in 182cd5f

split-debuginfo = "unpacked"

).

Anyway, I landed this on the rustc side, so closing this PR.

[samueltardieu]

Maybe it would be better if Clippy configured this through its .cargo/config.toml file instead

Good idea, I'll try that!

[flip1995]

That was my bad! I added the unexpected_cfgs section in the latest Rust->Clippy sync. Then when syncing back, I wasn't careful enough and the profile section that was previously removed during a sync got re-added again in the Rust repo.

Sorry for the inconvenience.

[samueltardieu]

I'll add a test to check that we don't have any profile section in Clippy's Cargo.toml files.