Skip to content

Conversation

@Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Jul 15, 2025

Needed to split the lint crate.

Both the method and loop versions of the lint should also behave the same now.

changelog: None

@rustbot
Copy link
Collaborator

rustbot commented Jul 15, 2025

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 15, 2025
@rustbot

This comment has been minimized.

Copy link
Member

@y21 y21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, unifying the code paths for the two versions is a nice improvement 👍

View changes since this review

@rustbot
Copy link
Collaborator

rustbot commented Oct 28, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@y21 y21 added this pull request to the merge queue Nov 1, 2025
Merged via the queue into rust-lang:master with commit 31d8210 Nov 1, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants