fix: metadata-collector lists wrong affected lints #12088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| r? @Manishearth (rustbot has picked a reviewer for you, use r? to override) |
rustbot added the S-waiting-on-review 
granddaifuku changed the title 
Manishearth approved these changes Jan 4, 2024
| @bors r+ |
| ☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
fixes #12042
This PR addresses the issue where the
metadata collectorincorrectly generates theAffected Lintssection when a comma is included in the configuration documentation.I made adjustments; however, if the
/// Lint: SOMETHINGsection ends with.it always produces the correct output.For example,
/// Lint: PUB_UNDERSCORE_FIELDSshould be
/// Lint: PUB_UNDERSCORE_FIELDS.changelog: none