Ignore wildcards in function arguments and local bindings #11454
Conversation
| r? @Centri3 (rustbot has picked a reviewer for you, use r? to override) |
rustbot added the S-waiting-on-review 
| | ||
| impl<'tcx> LateLintPass<'tcx> for IgnoredUnitPatterns { | ||
| fn check_pat(&mut self, cx: &LateContext<'tcx>, pat: &'tcx hir::Pat<'tcx>) { | ||
| match get_parent_node(cx.tcx, pat.hir_id) { |
There was a problem hiding this comment.
nit: Can we extract this into a let-else, then match on the contained data?
There was a problem hiding this comment.
To be honest, I would even go further rather than use useless defensive programming by returning in the else. Would you concur that there should not exist any situation in which a pattern will not have a parent node (and moreover reach this method)? I could use .unwrap() here instead of a let/else.
There was a problem hiding this comment.
You could use tcx.hir().get_parent() instead. Since this is a pattern that should be true, yeah, since it's always in a body.
There was a problem hiding this comment.
The same holds for the Node::Param we get, it must have a parent, I'll do the same change.
tests/ui/ignored_unit_patterns.rs Outdated
| pub fn moo(_: () /* Do not lint */) { | ||
| // Lint | ||
| let _ = foo().unwrap(); | ||
| // Do not lint | ||
| let _: () = foo().unwrap(); | ||
| // Do not lint | ||
| let _: () = (); | ||
| } |
There was a problem hiding this comment.
Can we use ui_test error annotations here? Like:
| pub fn moo(_: () /* Do not lint */) { | |
| // Lint | |
| let _ = foo().unwrap(); | |
| // Do not lint | |
| let _: () = foo().unwrap(); | |
| // Do not lint | |
| let _: () = (); | |
| } | |
| pub fn moo(_: ()) { | |
| let _ = foo().unwrap(); | |
| //~^ ERROR: blah blah blah | |
| let _: () = foo().unwrap(); | |
| let _: () = (); | |
| } |
Can you also add them to the already existing tests as well?
There was a problem hiding this comment.
Done (in a separate and prior commit for the existing tests).
samueltardieu force-pushed the issue-11403 branch 2 times, most recently from 107669f to 8421856 Compare samueltardieu force-pushed the issue-11403 branch from 8421856 to 2f5c445 Compare 
| This version looks good to me. Thanks! @bors r+ |
| ☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
4 participants
Fix #11403
changelog: none