What it does

check function names that end _unchecked and then squark if they are not marked as unsafe.

Maybe I'm totally out of line here but I think if you're saying 'trust me' it should be marked unsafe so you can say why it's safe to use the unchecked version.

Lint Name

safe_unchecked

Category

correctness, suspicious

Advantage

The suggestion would be to add unsafe to the function call. That could cause knock on compilation failures but they would have to be for the dev to fix manually as we can't say why they think it's safe.

If we have codebases where unsafe is swept under the carpet then all of rust is built on shaky ground.

Drawbacks

False positives?

Example

pub fn byte_to_str_unchecked(bytes: &[u8]) -> &str { unsafe { #[allow(clippy::transmute_bytes_to_str)]	mem::transmute(bytes) } }

Could be written as:

pub unsafe fn byte_to_str_unchecked(bytes: &[u8]) -> &str { unsafe { #[allow(clippy::transmute_bytes_to_str)]	mem::transmute(bytes) } }