This repository was archived by the owner on Dec 29, 2022. It is now read-only.
Update cargo #635
Merged
Update cargo #635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Pulls in a few changes to get rls working with master `cargo` again. This also updates the RLS to the point that it compiles again, but it's not quite passing tests yet.
Right now there's a lock around setting global things like env vars, so add handling of the cwd to this and manage requests from Cargo to change the cwd as well.
Now that this can change while the rls is running any access needs to be arbitrated through the environment lock or the variable needs to be passed in
| The test failures are an unrelated rustfmt issue. Thanks Alex! |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR has a few commits which culminates in the ability to upgrade Cargo in the main repo, accounting for recent changes in Cargo particularly around how the cwd is handled.