Added links to descriptions of XID_start and XID_continue in identifiers section. #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mrhota reviewed Apr 25, 2017
src/identifiers.md Outdated
| > character ranges used to form the more familiar C and Java language-family | ||
| > identifiers. | ||
| Links to Unicode descriptions: |
There was a problem hiding this comment.
Perhaps it would be nicer to use references like the [keywords] and/or [^non_ascii_idents] lines below. You wouldn't need this block; the external links would live on the text itself.
There was a problem hiding this comment.
Thanks, for the suggestion.I have made the changes.
| @VinithKrishnan I think it's ok to leave the backticks around the words, inside the brackets. |
steveklabnik approved these changes Apr 26, 2017
| Thank you so much! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.