Update proc_macro_attribute to use the attribute template #1889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rustbot added the S-waiting-on-review 
This comment has been minimized.
This comment has been minimized.
ehuss force-pushed the proc_macro_attribute branch from efe3a07 to 5b3be44 Compare 
traviscross force-pushed the proc_macro_attribute branch from 5b3be44 to de6037e Compare This comment has been minimized.
This comment has been minimized.
ehuss force-pushed the proc_macro_attribute branch from de6037e to 881b807 Compare This comment has been minimized.
This comment has been minimized.
ehuss force-pushed the proc_macro_attribute branch from 881b807 to ef9d863 Compare This comment has been minimized.
This comment has been minimized.
traviscross force-pushed the proc_macro_attribute branch from 192d0bf to e1d9735 Compare This comment has been minimized.
This comment has been minimized.
This renames this section to follow the attribute template. Although I like the old title, since it describes what it does, I would prefer to not make exceptions and stay consistent.
traviscross force-pushed the proc_macro_attribute branch from e1d9735 to dd41f1f Compare | This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
traviscross approved these changes Oct 21, 2025
rustbot removed the S-waiting-on-review Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
New rules:
macro.proc.attribute.syntaxmacro.proc.attribute.allowed-positionsmacro.proc.attribute.duplicatesmacro.proc.attribute.namespacemacro.proc.attribute.use-positionsmacro.proc.attribute.behaviorRenamed rules:
macro.proc.attribute.defsplit intomacro.proc.attribute.allowed-positionsandmacro.proc.attribute.behavior