Skip to content

Conversation

@RalfJung
Copy link
Member

@RalfJung RalfJung commented Feb 9, 2024

const_intrinsic_copy stabilization got reverted in rust-lang/rust#117905.

@RalfJung RalfJung changed the title re-add const_intrinsic_copy feature fix feature flags Feb 9, 2024
@RalfJung RalfJung force-pushed the const_intrinsic_copy branch from 9827731 to 45f82c2 Compare February 9, 2024 21:06
@RalfJung
Copy link
Member Author

RalfJung commented Feb 9, 2024

Okay this is painful, we'll need a bunch of careful #[cfg] in the lib.rs that enables exactly the stdarch features needed for each configuration. Enabling features that don't exist for the current target just shows "unknown feature" errors...

@RalfJung RalfJung force-pushed the const_intrinsic_copy branch from 438d26f to 047ba0a Compare February 9, 2024 21:20
Copy link
Member

@programmerjake programmerjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming it compiles everywhere, lgtm!

@calebzulawski calebzulawski merged commit f505736 into rust-lang:master Feb 9, 2024
@calebzulawski
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants