finally stop using min/max_value and the integer modules #1206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @bors r+ |
| 📌 Commit 148269d has been approved by |
| Heh, cool! |
| ☀️ Test successful - checks-travis, status-appveyor |
eddyb reviewed Mar 5, 2020
| let exp = if exp > i16::MAX as i32 { | ||
| i16::MAX | ||
| } else if exp < i16::MIN as i32 { | ||
| i16::MIN |
There was a problem hiding this comment.
Hmm I wonder if we can also make similar changes to rustc_apfloat. Ugh the licensing mess there isn't sorted out yet, is it...?
There was a problem hiding this comment.
I mean after the hard time you gave me for editing a comment in apfloat, I am not touching that code ever again if I can help it.^^
There was a problem hiding this comment.
I am not going to touch it either until I hear back about the licensing, don't worry, this was more of a note to myself.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
rust-lang/rust#68952 landed, so we can finally do this :)