Skip to content

Ensure cargo fmt is run on all files #4454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 13, 2025
Merged

Ensure cargo fmt is run on all files #4454

merged 3 commits into from
May 13, 2025

Conversation

tgross35
Copy link
Contributor

See the commit messages for details.
@rustbot rustbot added ctest Issues relating to the ctest crate O-windows S-waiting-on-review labels May 13, 2025
tgross35 added 3 commits May 13, 2025 21:20
@tgross35
Run cargo fmt from the workspace root
adcb2b8
@tgross35
ci: Run cargo fmt for the entire workspace
1ca8b36 
Currently only `src/` is checked. Add a run that covers everything else. This does mean files in `src/` get formatted twice, but `cargo fmt` doesn't support an `--exclude` option.
@tgross35
ci: Don't exclude ctest/
654bf4e 
There are no longer any shell files in `ctest/`, so this FIXME can be resolved. Also move this to the end so missing shellcheck doesn't exit before the sort checks.
@tgross35 tgross35 enabled auto-merge May 13, 2025 21:23
@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label May 13, 2025
@tgross35 tgross35 added this pull request to the merge queue May 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 13, 2025
@tgross35 tgross35 added this pull request to the merge queue May 13, 2025
Merged via the queue into rust-lang:main with commit c7c63ef May 13, 2025
50 checks passed
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Jun 1, 2025
@tgross35
Run cargo fmt from the workspace root
4b86b57 
(backport <rust-lang#4454>) (cherry picked from commit adcb2b8)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Jun 1, 2025
@tgross35
ci: Run cargo fmt for the entire workspace
41144e9 
Currently only `src/` is checked. Add a run that covers everything else. This does mean files in `src/` get formatted twice, but `cargo fmt` doesn't support an `--exclude` option. (backport <rust-lang#4454>) (cherry picked from commit 1ca8b36)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Jun 1, 2025
@tgross35
ci: Don't exclude ctest/
8a2f626 
There are no longer any shell files in `ctest/`, so this FIXME can be resolved. Also move this to the end so missing shellcheck doesn't exit before the sort checks. (backport <rust-lang#4454>) [ Note - this backport doesn't do much since `ctest/` was never excluded, but it does keep file structure in sync - Trevor ] (cherry picked from commit 654bf4e)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Jun 1, 2025
@tgross35
Run cargo fmt from the workspace root
28e6ae2 
(backport <rust-lang#4454>) (cherry picked from commit adcb2b8)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Jun 1, 2025
@tgross35
ci: Run cargo fmt for the entire workspace
a2189ad 
Currently only `src/` is checked. Add a run that covers everything else. This does mean files in `src/` get formatted twice, but `cargo fmt` doesn't support an `--exclude` option. (backport <rust-lang#4454>) (cherry picked from commit 1ca8b36)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Jun 1, 2025
@tgross35
ci: Don't exclude ctest/
3b98e7d 
There are no longer any shell files in `ctest/`, so this FIXME can be resolved. Also move this to the end so missing shellcheck doesn't exit before the sort checks. (backport <rust-lang#4454>) [ note - this backport doesn't do much since `ctest/` was never excluded, but it does keep file structure in sync - Trevor ] (cherry picked from commit 654bf4e)
@tgross35 tgross35 mentioned this pull request Jun 1, 2025
Merged
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Jun 2, 2025
@tgross35 tgross35 deleted the cargo-fmt branch June 2, 2025 01:05
DorianNiemiecSVRJS pushed a commit to DorianNiemiecSVRJS/rust-libc that referenced this pull request Jun 21, 2025
@tgross35 @DorianNiemiecSVRJS
Run cargo fmt from the workspace root
830958e 
(backport <rust-lang#4454>) (cherry picked from commit adcb2b8)
DorianNiemiecSVRJS pushed a commit to DorianNiemiecSVRJS/rust-libc that referenced this pull request Jun 21, 2025
@tgross35 @DorianNiemiecSVRJS
ci: Run cargo fmt for the entire workspace
bc6cd53 
Currently only `src/` is checked. Add a run that covers everything else. This does mean files in `src/` get formatted twice, but `cargo fmt` doesn't support an `--exclude` option. (backport <rust-lang#4454>) (cherry picked from commit 1ca8b36)
DorianNiemiecSVRJS pushed a commit to DorianNiemiecSVRJS/rust-libc that referenced this pull request Jun 21, 2025
@tgross35 @DorianNiemiecSVRJS
ci: Don't exclude ctest/
d2e44c8 
There are no longer any shell files in `ctest/`, so this FIXME can be resolved. Also move this to the end so missing shellcheck doesn't exit before the sort checks. (backport <rust-lang#4454>) [ note - this backport doesn't do much since `ctest/` was never excluded, but it does keep file structure in sync - Trevor ] (cherry picked from commit 654bf4e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ctest Issues relating to the ctest crate O-windows S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch

2 participants

@tgross35 @rustbot