Skip to content

hermit: make stat::st_size signed #4298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2025
Merged

hermit: make stat::st_size signed #4298

merged 1 commit into from
Mar 7, 2025

Conversation

@mkroening
Copy link
Contributor

@mkroening mkroening commented Mar 5, 2025 •
edited
Loading

Description

This PR changes Hermit's stat::st_size from u64 to i64.

Sources

This was done upstream in hermit-os/kernel#1576 to comply with POSIX.

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI
@rustbot
Copy link
Collaborator

rustbot commented Mar 5, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer
tgross35
tgross35 approved these changes Mar 7, 2025
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
@tgross35 tgross35 added this pull request to the merge queue Mar 7, 2025
@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Mar 7, 2025
Merged via the queue into rust-lang:libc-0.2 with commit 6f7b167 Mar 7, 2025
44 checks passed
@tgross35
Copy link
Contributor

tgross35 commented Mar 7, 2025

Oh I didn't catch that this is to the wrong branch, in the future please make PRs against main and then I backport from there.
@tgross35 tgross35 added main-needs-cherry-pick This PR was merged against libc-0.2 but does not yet exist in main. and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Mar 7, 2025
@mkroening mkroening deleted the hermit-st_size branch March 7, 2025 08:07
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Mar 10, 2025
@mkroening @tgross35
hermit: make stat::st_size signed
cefa840 
(apply <rust-lang#4298> to `main`) (cherry picked from commit 8f5b7b6)
@tgross35 tgross35 mentioned this pull request Mar 10, 2025
Merged
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Mar 10, 2025
@mkroening @tgross35
hermit: make stat::st_size signed
46abfae 
(apply <rust-lang#4298> to `main`) (cherry picked from commit 8f5b7b6)
@tgross35 tgross35 added main-applied This PR was merged against libc-0.2 and main has since been updated to include it and removed main-needs-cherry-pick This PR was merged against libc-0.2 but does not yet exist in main. labels Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

main-applied This PR was merged against libc-0.2 and main has since been updated to include it S-waiting-on-review

3 participants

@mkroening @rustbot @tgross35