Use rustc's knowledge of LLVM/Clang target triples #1252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
madsmtm force-pushed the llvm-target branch 3 times, most recently from 880da47 to d351ff6 Compare Use the same LLVM target triple as rustc does
NobodyXu requested changes Nov 1, 2024
NobodyXu requested changes Nov 1, 2024
NobodyXu requested changes Nov 1, 2024
This was referenced Nov 1, 2024
clang: error: version 'softfloat' in target triple 'aarch64-unknown-none-softfloat' is invalid #1255
Closed
Merged
This was referenced Nov 1, 2024
glandium reviewed Nov 2, 2024
nicholasbishop added a commit to nicholasbishop/cc-rs that referenced this pull request Nov 3, 2024
This restores the behavior prior to rust-lang#1252, when the UEFI targets were hardcoded in src/lib.rs.
nicholasbishop added a commit to nicholasbishop/cc-rs that referenced this pull request Nov 3, 2024
This restores the behavior prior to rust-lang#1252, when the UEFI targets were hardcoded in src/lib.rs.
NobodyXu pushed a commit that referenced this pull request Nov 4, 2024
This restores the behavior prior to #1252, when the UEFI targets were hardcoded in src/lib.rs.
tgross35 pushed a commit to rust-lang/cmake-rs that referenced this pull request Feb 10, 2025
The workaround introduced in #39 is no longer necessary since `cc-rs` handles C++ requirements internally, and is in fact detrimental since `cc-rs` has required the target to be a `rustc` target triple since rust-lang/cc-rs#1225 / rust-lang/cc-rs#1252. Additionally, deprecate `uses_cxx11` which was introduced in the same PR. Fixes rust-lang/cc-rs#1276. I didn't update the dependency to anything specific, just a version that I know has the fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Part of #1249.
I tried to keep it separate from cleaning up the Apple stuff, but things were quite intertwined, so I ended up having to do some of it. Still, this PR aims to have as few functional changes as possible (the only effect should be that we now use the correct Clang target).
Fixes #542 (was fixed before, but now we do it properly by passing
arm64-apple-macosxinstead ofarm64-apple-darwin).Fixes #1255.
Fixes #1205.
Might improve the situation in #1005.
This affects (checking local test script...) 128 targets, though I feel pretty confident that the change is correct, and if it's not, then it's likely an issue in
rustcas well.