ci: Fix the binary size workflow #708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
tgross35 force-pushed the fix-binary-size-ci branch 2 times, most recently from 268e0bb to 98a2b82 Compare From the bootstrap error: thread 'main' panicked at src/bootstrap/src/core/config/config.rs:3283:21: `llvm.download-ci-llvm` cannot be set to `true` on CI. Use `if-unchanged` instead. So do that. Additionally pin rustc to hopefully prevent similar regressions in the future. Some settings to increase log output were also applied.
tgross35 force-pushed the fix-binary-size-ci branch from 98a2b82 to dade97a Compare 
workingjubilee approved these changes Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
From the bootstrap error:
So do that. Additionally, pin rustc to hopefully prevent similar regressions in the future.
Some settings to increase log output were also applied.