Skip to content

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Feb 12, 2025

This applies some fixes so that backtrace is compatible with Rust 2024. This is needed to migrate the standard library to 2024 since it directly embeds backtrace.

Copy link
Contributor

Code size changes for a hello-world Rust program linked with libstd with backtrace:

On platform ubuntu-latest:

  • Original binary size: 373,512 B
  • Updated binary size: 381,704 B
  • Difference: 8,192 B (2.19%)
@workingjubilee
Copy link
Member

Sorry, needs rebase for #697

ehuss added a commit to ehuss/backtrace-rs that referenced this pull request Feb 13, 2025
@workingjubilee
Copy link
Member

Thanks for the fixups and bearing with my nits!

@workingjubilee workingjubilee merged commit 9d2c34e into rust-lang:master Feb 13, 2025
41 checks passed
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Feb 14, 2025
…ubilee Update backtrace This updates the backtrace submodule. 6 commits in f8cc6ac9acc4e663ecd96f9bcf1ff4542636d1b9..9d2c34e7e63afe1e71c333b247065e3b7ba4d883 2025-01-04 03:37:47 +0100 to 2025-02-13 14:14:18 -0800 - Various cleanups: rust-lang/backtrace-rs#673 - libunwind: Use builtin _Unwind_GetIP for NuttX on ARM platform: rust-lang/backtrace-rs#692 - remove outdated docs part on Dbghelp::ensure_open: rust-lang/backtrace-rs#696 - Cleanup Windows trace modules: rust-lang/backtrace-rs#697 - Attempt to fix ARM32 Windows: rust-lang/backtrace-rs#685 - Prepare backtrace for Rust 2024: rust-lang/backtrace-rs#700
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Feb 14, 2025
…ubilee Update backtrace This updates the backtrace submodule. 6 commits in f8cc6ac9acc4e663ecd96f9bcf1ff4542636d1b9..9d2c34e7e63afe1e71c333b247065e3b7ba4d883 2025-01-04 03:37:47 +0100 to 2025-02-13 14:14:18 -0800 - Various cleanups: rust-lang/backtrace-rs#673 - libunwind: Use builtin _Unwind_GetIP for NuttX on ARM platform: rust-lang/backtrace-rs#692 - remove outdated docs part on Dbghelp::ensure_open: rust-lang/backtrace-rs#696 - Cleanup Windows trace modules: rust-lang/backtrace-rs#697 - Attempt to fix ARM32 Windows: rust-lang/backtrace-rs#685 - Prepare backtrace for Rust 2024: rust-lang/backtrace-rs#700
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 14, 2025
Rollup merge of rust-lang#136992 - ehuss:update-backtrace, r=workingjubilee Update backtrace This updates the backtrace submodule. 6 commits in f8cc6ac9acc4e663ecd96f9bcf1ff4542636d1b9..9d2c34e7e63afe1e71c333b247065e3b7ba4d883 2025-01-04 03:37:47 +0100 to 2025-02-13 14:14:18 -0800 - Various cleanups: rust-lang/backtrace-rs#673 - libunwind: Use builtin _Unwind_GetIP for NuttX on ARM platform: rust-lang/backtrace-rs#692 - remove outdated docs part on Dbghelp::ensure_open: rust-lang/backtrace-rs#696 - Cleanup Windows trace modules: rust-lang/backtrace-rs#697 - Attempt to fix ARM32 Windows: rust-lang/backtrace-rs#685 - Prepare backtrace for Rust 2024: rust-lang/backtrace-rs#700
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Feb 17, 2025
Update backtrace This updates the backtrace submodule. 6 commits in f8cc6ac9acc4e663ecd96f9bcf1ff4542636d1b9..9d2c34e7e63afe1e71c333b247065e3b7ba4d883 2025-01-04 03:37:47 +0100 to 2025-02-13 14:14:18 -0800 - Various cleanups: rust-lang/backtrace-rs#673 - libunwind: Use builtin _Unwind_GetIP for NuttX on ARM platform: rust-lang/backtrace-rs#692 - remove outdated docs part on Dbghelp::ensure_open: rust-lang/backtrace-rs#696 - Cleanup Windows trace modules: rust-lang/backtrace-rs#697 - Attempt to fix ARM32 Windows: rust-lang/backtrace-rs#685 - Prepare backtrace for Rust 2024: rust-lang/backtrace-rs#700
github-actions bot pushed a commit to tautschnig/verify-rust-std that referenced this pull request Mar 11, 2025
…ubilee Update backtrace This updates the backtrace submodule. 6 commits in f8cc6ac9acc4e663ecd96f9bcf1ff4542636d1b9..9d2c34e7e63afe1e71c333b247065e3b7ba4d883 2025-01-04 03:37:47 +0100 to 2025-02-13 14:14:18 -0800 - Various cleanups: rust-lang/backtrace-rs#673 - libunwind: Use builtin _Unwind_GetIP for NuttX on ARM platform: rust-lang/backtrace-rs#692 - remove outdated docs part on Dbghelp::ensure_open: rust-lang/backtrace-rs#696 - Cleanup Windows trace modules: rust-lang/backtrace-rs#697 - Attempt to fix ARM32 Windows: rust-lang/backtrace-rs#685 - Prepare backtrace for Rust 2024: rust-lang/backtrace-rs#700
github-actions bot pushed a commit to tautschnig/verify-rust-std that referenced this pull request Mar 11, 2025
…ubilee Update backtrace This updates the backtrace submodule. 6 commits in f8cc6ac9acc4e663ecd96f9bcf1ff4542636d1b9..9d2c34e7e63afe1e71c333b247065e3b7ba4d883 2025-01-04 03:37:47 +0100 to 2025-02-13 14:14:18 -0800 - Various cleanups: rust-lang/backtrace-rs#673 - libunwind: Use builtin _Unwind_GetIP for NuttX on ARM platform: rust-lang/backtrace-rs#692 - remove outdated docs part on Dbghelp::ensure_open: rust-lang/backtrace-rs#696 - Cleanup Windows trace modules: rust-lang/backtrace-rs#697 - Attempt to fix ARM32 Windows: rust-lang/backtrace-rs#685 - Prepare backtrace for Rust 2024: rust-lang/backtrace-rs#700
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants