Skip to content

Conversation

Philippe-Cholet
Copy link
Member

ZipSlices was removed in 0.5.0.
Is there a point of keeping this around?!

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.36%. Comparing base (6814180) to head (e859686).
Report is 44 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@ ## master #911 +/- ## ========================================== - Coverage 94.38% 94.36% -0.03%  ========================================== Files 48 48 Lines 6665 6815 +150 ========================================== + Hits 6291 6431 +140  - Misses 374 384 +10 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Philippe-Cholet Philippe-Cholet requested a review from jswrenn April 9, 2024 16:45
Copy link
Member

@jswrenn jswrenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see any reason we need to keep this around. Should the need arise for it, we can always add it back.

@Philippe-Cholet Philippe-Cholet added this to the next milestone Apr 10, 2024
@Philippe-Cholet Philippe-Cholet added this pull request to the merge queue Apr 10, 2024
Merged via the queue into rust-itertools:master with commit 6de2f5c Apr 10, 2024
@Philippe-Cholet Philippe-Cholet deleted the zipslices branch April 10, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants