[#experiment ]Associated Reader/Writer #922
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rmsyn reviewed Mar 12, 2025
Contributor
rmsyn left a comment
rmsyn left a comment There was a problem hiding this comment.
But it is slower to compile:
For example stm32f4 crate on old PC:
Before PR: 6.92 s
After PR: 10.23 s
Not completely sure what created the drastic increase in compile times. However, maybe removing the extra trait resolution will bring it back down?
Comment on lines +108 to +115
| pub trait FromBits<U> { | ||
| unsafe fn from_bits(b: U) -> Self; | ||
| } | ||
| | ||
| #[doc(hidden)] | ||
| pub trait ToBits<U> { | ||
| fn to_bits(&self) -> U; | ||
| } |
Contributor
There was a problem hiding this comment.
If these traits are not intended to be used externally, maybe we can implement Readable without the extra layer of trait resolution?
I'm thinking along the lines of creating a helper macro to implement the Readable trait on the needed types.
Member Author
There was a problem hiding this comment.
I forgot about inline.
Now it is 7.94 s
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Related to #902
@rmsyn This is required step to make register write methods generic over crates: https://github.com/burrbull/reg
But it is slower to compile:
For example stm32f4 crate on old PC:
Before PR: 6.92 s
After PR: 10.23 s