Skip to content

Add support for building the e310x crate #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
japaric merged 3 commits into from
Mar 3, 2018
Merged

Add support for building the e310x crate #185

japaric merged 3 commits into from
Mar 3, 2018

Conversation

@dvc94ch
Copy link
Member

@dvc94ch dvc94ch commented Mar 3, 2018

No description provided.

dvc94ch added 2 commits March 1, 2018 08:58
@dvc94ch
Add RISCV target.
20249ca
@dvc94ch
Generate interrupt dispatch code.
6112ab8 
Useful for architectures that prefer dispatching interrupts in software.
This was referenced Mar 3, 2018
Closed
Closed
@jamesmunns jamesmunns self-requested a review March 3, 2018 11:04
@jamesmunns
Copy link
Member

jamesmunns commented Mar 3, 2018

Hey @dvc94ch, it looks generally good to me, would you mind adding some good RISC-V examples (or at least the e310x svd) to the regression tests? Check out /ci/script.sh (and let me know if you need help). This way we can make sure we don't accidentally break support when changing something else.

Once you do that, I can trigger CI and LGTM.
@dvc94ch
Copy link
Member Author

dvc94ch commented Mar 3, 2018 •
edited
Loading

@jamesmunns Thank you for the quick review! I won't get around to it till tomorrow.

Found some time today after all...
@jamesmunns
Copy link
Member

jamesmunns commented Mar 3, 2018

Thanks! Lets see how CI goes.

bors r+
bors bot added a commit that referenced this pull request Mar 3, 2018
@bors
Merge #185
e220379 
185: Add support for building the e310x crate r=jamesmunns a=dvc94ch
@bors
Copy link
Contributor

bors bot commented Mar 3, 2018

Timed out
@dvc94ch
Copy link
Member Author

dvc94ch commented Mar 3, 2018

I'm getting permission denied when I click the red cross [0], can you post a log?

[0] https://app.bors.tech/repositories/1953/log#batch-4578
@japaric
Copy link
Member

japaric commented Mar 3, 2018

All tests passed so merging manually.

I'll increase the timeout from 1 hour to 2.
@japaric japaric merged commit 1515894 into rust-embedded:master Mar 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@dvc94ch @jamesmunns @japaric