Replace #[inline(always)] by #[inline] due to the later being conside… #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…red harmful Signed-off-by: Daniel Egger <daniel@eggers-club.de>
Member
| ("being considered harmful" is not a very descriptive commit message / PR title, IMO.) For posteriority, could you please add a comment (or a link) with the rationale about the change to this PR? @homunkulus r+ |
Contributor
| 📌 Commit 73cd404 has been approved by |
Contributor
japaric pushed a commit that referenced this pull request Sep 20, 2017
Replace #[inline(always)] by #[inline] due to the later being conside… …red harmful Signed-off-by: Daniel Egger <daniel@eggers-club.de>
Contributor Author
| Well, according to https://rust-lang-nursery.github.io/rust-clippy/master/index.html#inline_always it is considered harmful: It increases compile time and may increase size as well as decrease performance. I'm afraid I can't come up with a better label than "considered harmful". |
Contributor
| ☀️ Test successful - status-appveyor, status-travis |
therealprof added a commit that referenced this pull request Jul 20, 2019
Turns out this @therealprof dude was wrong in blindly following general consensus that #[inline(always)] was a bad idea. Revisiting the topic showed that just #[inline] is not enough to get even very trivial functions inlined in dev mode which causes a ton of bloat and a lot of debugging fun due to many emitted extra functions without any value for the developer. Usual binary reductions by this change are in the area of 10-15% which is a lot given that even a simply blinky on Cortex-M0 is several kB already. E.g. before: 0.5% 100.0% 4.0KiB .text section size, the file size is 734.1KiB after: 0.5% 100.0% 3.7KiB .text section size, the file size is 714.5KiB Signed-off-by: Daniel Egger <daniel@eggers-club.de>
Merged
therealprof added a commit that referenced this pull request Jul 21, 2019
Turns out this @therealprof dude was wrong in blindly following general consensus that #[inline(always)] was a bad idea. Revisiting the topic showed that just #[inline] is not enough to get even very trivial functions inlined in dev mode which causes a ton of bloat and a lot of debugging fun due to many emitted extra functions without any value for the developer. Usual binary reductions by this change are in the area of 10-15% which is a lot given that even a simply blinky on Cortex-M0 is several kB already. E.g. before: 0.5% 100.0% 4.0KiB .text section size, the file size is 734.1KiB after: 0.5% 100.0% 3.7KiB .text section size, the file size is 714.5KiB Signed-off-by: Daniel Egger <daniel@eggers-club.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
…red harmful
Signed-off-by: Daniel Egger daniel@eggers-club.de