Update dependencies to latest stable and fix fallout #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Several dependencies had quite out of date and there are some nice stabilizations and features (for nix ioctl) upstream. Nothing here should change the external API. Signed-off-by: Paul Osborne <osbpau@gmail.com>
We only want to export the safe wrappers around these. Solve this by putting the generated pub functions inside an unexported module. Signed-off-by: Paul Osborne <osbpau@gmail.com>
Signed-off-by: Paul Osborne <osbpau@gmail.com>
nastevens approved these changes Jan 29, 2018
| /// This is the structure as used in the I2C_SMBUS ioctl call | ||
| #[repr(C)] | ||
| struct i2c_smbus_ioctl_data { | ||
| pub struct i2c_smbus_ioctl_data { |
There was a problem hiding this comment.
Up to you - this could potentially go in the mod ioctl below
There was a problem hiding this comment.
I started to play around with this and it ended up requiring a bunch more changes. I think I'm OK with this leaking since ffi isn't pub itself and is just used internally.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Several dependencies had quite out of date and there are some nice
stabilizations and features (for nix ioctl) upstream. Nothing here
should change the external API