Skip to content

Conversation

mini-ninja-64
Copy link
Contributor

This PR adds FPU initialization when compiling with the f or d extensions, for the implementation of this I have updated the parse_target function from build.rs to support additional extensions, this is required until this crate is updated to rust 1.75 at which point we can use target_feature.

I added a little macro to help with zeroing registers, if it is preferable though happy to inline the zeroing of registers

I am new to rust & risc-v in general so apologies if there is any obvious mistakes that have been made, your feedback is greatly appreciated.

closes: #157

@mini-ninja-64 mini-ninja-64 requested a review from a team as a code owner December 11, 2023 00:29
@romancardenas
Copy link
Contributor

Thanks! I'll review your PR ASAP

Copy link
Contributor

@romancardenas romancardenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!! I'll let a couple of days in case anyone from @rust-embedded/risc-v finds any issue and then I'll add it to the merge queue

@romancardenas romancardenas changed the title Implement FPU initialization riscv-rt: Implement FPU initialization Dec 14, 2023
@romancardenas romancardenas added this pull request to the merge queue Dec 19, 2023
Merged via the queue into rust-embedded:master with commit 0452207 Dec 19, 2023
@mini-ninja-64
Copy link
Contributor Author

wooo, thank you so much ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants