Make statics const #91
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
With recent compiler versions we get warnings for this code where it suggests using `addr_of!` to avoid taking the intermediate reference to a static mut variable. However, there's no clear reason why these even need to be mut. Embassy-boot doesn't use mut. So let's change it so people copying this don't get that same unhelpful warning.
| Ok, so my changes don't work, but also this file appears to be full of UB... |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
With recent compiler versions we get warnings for this code where it suggests using
addr_of!to avoid taking the intermediate reference to a static mut variable.However, there's no clear reason why these even need to be mut. Embassy-boot doesn't use mut. So let's change it so people copying this don't get that same unhelpful warning.