Skip to content

--no-show-raw-insn with one '-' #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 11, 2022
Merged

--no-show-raw-insn with one '-' #84

merged 6 commits into from
Aug 11, 2022

Conversation

@alexgoto
Copy link
Contributor

@alexgoto alexgoto commented Jul 17, 2022

Related issue #83
@alexgoto alexgoto requested a review from a team as a code owner July 17, 2022 14:25
@rust-highfive
Copy link

rust-highfive commented Jul 17, 2022

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @therealprof (or someone else) soon.

Please see the contribution instructions for more information.
@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources labels Jul 17, 2022
@alexgoto alexgoto mentioned this pull request Jul 18, 2022
Closed
@adamgreig
Copy link
Member

adamgreig commented Jul 19, 2022

Thanks! It looks like -print-imm-hex needs two dashes too?
@alexgoto
Copy link
Contributor Author

alexgoto commented Jul 19, 2022 •
edited
Loading

@adamgreig

Thanks! It looks like -print-imm-hex needs two dashes too?

Checked again. Yes it is.
adamgreig
adamgreig approved these changes Jul 20, 2022
View reviewed changes
Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

bors r+
bors bot added a commit that referenced this pull request Jul 20, 2022
@bors @alexgoto
Merge #84
c2a20dd 
84: --no-show-raw-insn with one '-' r=adamgreig a=alexgoto Related issue #83 Co-authored-by: Alexandr Gotovtsev <main.agot11@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jul 20, 2022

Build failed:
@adamgreig
Copy link
Member

adamgreig commented Aug 11, 2022

Please could you rebase onto master now we've fixed the CI?
@eldruin
Copy link
Member

eldruin commented Aug 11, 2022

bors would test after the merge to master, right?
bors r+
@bors
Copy link
Contributor

bors bot commented Aug 11, 2022

Build succeeded:
@bors bors bot merged commit d50b97f into rust-embedded:master Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources

5 participants

@alexgoto @rust-highfive @adamgreig @eldruin @therealprof