move code to the 2018 edition #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| LGTM |
this commit removes features gate from the code and from Cargo.toml it also makes use of the new `--edition` flag to simplify the instructions for creating a new project
Member Author
| Latest commit prepares this book for the upcoming beta release. r? @rust-embedded/resources |
Member Author
| @therealprof Thanks! bors r+ |
bors bot added a commit that referenced this pull request Sep 14, 2018
19: move code to the 2018 edition r=japaric a=japaric most code changes are minor the annoying part of using the 2018 edition right now is that there is no easy way to create new 2018 project (Cargo still defaults to 2015 projects; see rust-lang/cargo#5980) and there's no visible documentation on how to move a new project to the 2018 edition (see rust-lang/edition-guide#102) so I have included the required changes in the preface -- I hope people won't miss that part. r? @rust-embedded/resources (anyone) closes #1 Co-authored-by: Jorge Aparicio <jorge@japaric.io>
Contributor
Build succeeded |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
most code changes are minor
the annoying part of using the 2018 edition right now is that there is no easy
way to create new 2018 project (Cargo still defaults to 2015 projects; see
rust-lang/cargo#5980) and there's no visible documentation on how to move a new
project to the 2018 edition (see rust-lang/edition-guide#102) so I have
included the required changes in the preface -- I hope people won't miss that
part.
r? @rust-embedded/resources (anyone)
closes #1