Fix _stack_end usage and doc #577
Merged
+7 −5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
1) `paint-stack` feature used `__sheap` as a lower boundary. It is not an error until the `_stack_end` is overrided by `cortex-m-rt` user. If overrided, it can potentially cause writting over memory between `__sheap` and `_stack_end` addresses. 2) `_stack_end` was checked for being less or equal to `_stack_start`, but documentation declared `_stack_end` is not used internally.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
paint-stackfeature used__sheapas a lower boundary. It is not an erroruntil the
_stack_endis overrided bycortex-m-rtuser. If overrided, itcan potentially cause writting over memory between
__sheapand_stack_endaddresses._stack_endis checked for being less or equal to_stack_start, butdocumentation declared
_stack_endis not used internally.