Don't unmarshal classes that don't include XMLRPC::Marshal #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
kou reviewed Apr 16, 2023
There was a problem hiding this comment.
Could you pretty-print this XML like other XML in test/data/?
lib/xmlrpc/parser.rb Outdated
| obj.instance_variable_set("@#{ key }", value) if key =~ /^([a-zA-Z_]\w*)$/ | ||
| } | ||
| obj | ||
| if mod.included_modules.include? XMLRPC::Marshallable |
There was a problem hiding this comment.
Could you return hash when this condition is false like #35?
ooooooo-q force-pushed the fix/parse_class branch from 9df4cc9 to 5b1ae82 Compare 
| @kou We should merge this instead of #35. Because @ooooooo-q has been reported this to h1 at May, 2021. |
kou reviewed Aug 1, 2023
kou changed the title 
| Thanks. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
If we unmarshal all classes, evil clients may run unexpected code.
See https://hackerone.com/reports/1189419 for details.