Fix a bug that scan_until behaves differently with Regexp and String patterns #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
naitoh force-pushed the fix_scan_until_pre_match_matched branch from 1d19d32 to 94c8e3f Compare 
kou changed the title 
Member
| Thanks. |
matzbot pushed a commit to ruby/ruby that referenced this pull request Feb 17, 2025
Regexp and String patterns (ruby/strscan#138) Fix ruby/strscan#131 ruby/strscan@e1cec2e726
mrzasa pushed a commit to mrzasa/ruby that referenced this pull request Feb 21, 2025
Regexp and String patterns (ruby/strscan#138) Fix ruby/strscan#131 ruby/strscan@e1cec2e726
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix GH-131