Skip to content

Fix test failures on ruby HEAD #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2025
Merged

Fix test failures on ruby HEAD #56

merged 1 commit into from
May 5, 2025

Conversation

@k-tsj
Copy link
Member

@k-tsj k-tsj commented May 5, 2025

@k-tsj k-tsj merged commit a7dab94 into ruby:master May 5, 2025
51 of 53 checks passed
@k-tsj k-tsj deleted the fix-failures-on-head branch May 5, 2025 05:20
@k-tsj k-tsj mentioned this pull request May 5, 2025
Closed
@k-tsj
Copy link
Member Author

k-tsj commented May 5, 2025

NOTE:

Even with this fix, <Struct subclass>.new still doesn't work properly. I'll document it as a "known limitation" later.
@tenderlove
Copy link
Member

tenderlove commented May 14, 2025

@k-tsj is there any chance we can release this as a gem? I would like to merge this PR, but Ruby CI is red until this is released. 🙇
@k-tsj
Copy link
Member Author

k-tsj commented May 15, 2025

@tenderlove I updated gems/bundled_gems. Could you try it?
@tenderlove
Copy link
Member

tenderlove commented May 15, 2025

@k-tsj that did it! Thank you so much!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@k-tsj @tenderlove