Update load path modification in mspec-run.rb #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
| Mmh, weird, I don't think any of the commands/* files are really meant to be executable. Could you remove the There are launchers for each under |
There are wrappers for the commands in bin. Remove the executable file permission, the shebang and the load path modifications.
Member Author
| Updated, everything related to executing the files is gone |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This file has probably been moved at some point, the old version would to
lib/mspec/libwhich does not exist. The new version is inspired by the syntax ofbin/mspec-runto keep things consistent.Since the usual way to call this script is via
bin/mspec-run, and that sets up your load path, an alternative way to fix this would be to simply remove this load path update in this file.