Don't depend on Fiddle features which aren't in Ruby 3.0 #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The fiddle gem has changed more than I thought! We can't depend on CONST_STRING being available, nor the Fiddle::Type module. Thankfully, passing strings _in_ as VOIDP or CONST_STRING works the same, and we don't need to look at any string results, so we can just use the old/new types interchangeably.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The fiddle gem has changed more than I thought! We can't depend on CONST_STRING being available, nor the Fiddle::Type module. Thankfully, passing strings in as VOIDP or CONST_STRING works the same, and we don't need to look at any string results, so we can just use the old/new types interchangeably.