Add script to check require_relative for spec_helper #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
spec_helper is in each *_spec.rb file.
eregon added a commit to ruby/spec that referenced this pull request Jan 17, 2023
seven1m pushed a commit to seven1m/ruby_spec that referenced this pull request Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Adds a script that can be used to check that
require_relativefor spec_helper is in each *_spec.rb file. Having the require in each file is helpful so each spec can be easily run standalone with ruby from the command line.This is in response to ruby/spec#992 per @eregon 's request.
Note that this is a simple check for "require_relative .*spec_helper" in each *_spec.rb file and it would incorrectly fail the case where a *_spec.rb file required another file which required spec_helper.