Skip to content

Set filename when initializing logger with a File object #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2019
Merged

Set filename when initializing logger with a File object #30

merged 1 commit into from
May 18, 2019

Conversation

@jeremyevans
Copy link
Contributor

@jeremyevans jeremyevans commented May 17, 2019 •
edited by sonots
Loading

This should allow reopen to work. Requested in ruby issue #14595
@jeremyevans
Set filename when initializing logger with a File object
bd367af 
This should allow reopen to work. Requested in ruby issue #14595.
@ioquatix ioquatix merged commit 185abc2 into ruby:master May 18, 2019
@ioquatix
Copy link
Member

ioquatix commented May 18, 2019

LGTM.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@jeremyevans @ioquatix