Add undef: :replace for CSV.open #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor Author
| #90 has been opened for this issue but lacks activity. |
kou reviewed Jun 1, 2020
lib/csv.rb Outdated
| # wrap a File opened with the remaining +args+ with no newline | ||
| # decorator | ||
| file_opts = {universal_newline: false}.merge(options) | ||
| file_opts.merge!(undef: options.delete(:undef), replace: options.delete(:replace)) |
Member
There was a problem hiding this comment.
Suggested change
| file_opts.merge!(undef: options.delete(:undef), replace: options.delete(:replace)) | |
| options.delete(:undef) | |
| options.delete(:replace) |
Contributor Author
There was a problem hiding this comment.
I updated it. Thanks for your review!
This PR adds `undef: :replace` option for `CSV.open`. `File.open` has `undef: :replace` option, but `CSV.open` does not. It would be convenient if `CSV.open` could have a shortcut by having `undef: :replace` option.
koic force-pushed the add_undef_replace_option_for_csv_open branch from 4c027bf to 625f721 Compare 
Member
| Thanks! |
koic added a commit to koic/csv that referenced this pull request Jun 3, 2020
This PR adds `invalid: :replace` for `CSV.open`. It is a PR similar to ruby#129. And this PR uses `String#scrub` to prevent the following `ArgumentError`. ```ruby /[,"]/.match?("\x82\xA0") #=> ArgumentError (invalid byte sequence in UTF-8) /[,"]/.match?("\x82\xA0".scrub) #=> false ```
koic added a commit to koic/csv that referenced this pull request Jun 4, 2020
This PR adds `invalid: :replace` for `CSV.open`. It is a PR similar to ruby#129. And this PR uses `String#scrub` to prevent the following `ArgumentError`. ```ruby /[,"]/.match?("\x82\xA0") #=> ArgumentError (invalid byte sequence in UTF-8) /[,"]/.match?("\x82\xA0".scrub) #=> false ```
koic added a commit to koic/csv that referenced this pull request Jun 4, 2020
This PR adds `invalid: :replace` for `CSV.open`. It is a PR similar to ruby#129. And this PR uses `String#scrub` to prevent the following `ArgumentError`. ```ruby /[,"]/.match?("\x82\xA0") #=> ArgumentError (invalid byte sequence in UTF-8) /[,"]/.match?("\x82\xA0".scrub) #=> false ```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR adds
undef: :replaceoption forCSV.open.File.openhasundef: :replaceoption, butCSV.opendoes not.It would be convenient if
CSV.opencould have a shortcut by havingundef: :replaceoption.