Skip to content

Conversation

@pezholio
Copy link
Contributor

@pezholio pezholio commented Aug 5, 2016

Updated from the latest upstream version of Swagger UI

@dblock
Copy link
Member

dblock commented Aug 6, 2016

Was this run via bundle exec rake swagger_ui:dist:update?

@pezholio
Copy link
Contributor Author

pezholio commented Aug 9, 2016

Yep, I think there might be an issue with the command as it took out a bunch of stuff I needed in the application.js, so there was some manual fiddling too.

@dblock
Copy link
Member

dblock commented Aug 9, 2016

That's what I meant. Check out https://github.com/ruby-grape/grape-swagger-rails/blob/master/lib/tasks/swagger_ui.rake#L23. It needs to be updated along with the distribution changes so that we can just run it next time. Now that you have a good, updated state it should be fairly easy, you can run it, look at changes it made on top of this, update the task, run again, until all you have left is the changes in the task. Could you please do that?

@pezholio
Copy link
Contributor Author

pezholio commented Aug 9, 2016

Ah, gotcha. No probs, will do that now

@pezholio
Copy link
Contributor Author

pezholio commented Aug 9, 2016

@dblock That's done now - the rake task now leaves me with a clean working directory, so all should be golden 👍

@dblock
Copy link
Member

dblock commented Aug 9, 2016

Perfect. Merging.

@dblock dblock merged commit d443bfd into ruby-grape:master Aug 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants