Skip to content

Change #before_filter to #before_action #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
m-o-e wants to merge 1 commit into from
Closed

Change #before_filter to #before_action #63

m-o-e wants to merge 1 commit into from

Conversation

@m-o-e
Copy link

@m-o-e m-o-e commented Jul 16, 2016

Closes #62
@dblock
Copy link
Member

dblock commented Jul 17, 2016

The problem here is that it's not backward compatible. For starters we definitely would need something like https://github.com/ruby-grape/grape-swagger/blob/master/UPGRADING.md here that explains what to do when upgrading.

I would actually prefer that the public interface cleanly deprecates the old method, ie. writes the old one in terms of the new one with a DEPRECATED warning, first.

It needs a CHANGELOG entry, too.
@m-o-e
Copy link
Author

m-o-e commented Jul 17, 2016

Sorry, I agree with your concerns but won't have time to work on this anytime soon.
Feel free to take this PR as a starting point or close it in favor to a better fix.
@dblock
Copy link
Member

dblock commented Jul 17, 2016

Thanks for your help @m-o-e, if someone wants to finish this, see ^^^.
@serggl serggl mentioned this pull request Sep 21, 2016
Merged
@serggl
Copy link
Member

serggl commented Sep 21, 2016

made a followup PR here: #70
@dblock
Copy link
Member

dblock commented Sep 21, 2016

Closing in favor of #70.
@dblock dblock closed this Sep 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@m-o-e @dblock @serggl