Remove grape and grape-swagger from dependencies #61
Conversation
aschuster3 force-pushed the remove-grape-dependencies branch 2 times, most recently from fcda131 to 8857d38 Compare 
| But we do want to test compatibility, so I think you cannot remove the Gemfile part. See https://github.com/ruby-grape/grape-swagger-rails/blob/master/.travis.yml#L17 being built. |
| source 'https://rubygems.org' | ||
| | ||
| gemspec | ||
| |
There was a problem hiding this comment.
This shouldn't be removed, see https://github.com/ruby-grape/grape-swagger-rails/blob/master/.travis.yml#L17.
There was a problem hiding this comment.
Ah, good point, I'll see what can be done about moving that to the gemspec definition instead.
There was a problem hiding this comment.
I don't think you want to. This is purely for testing gem compatibility, aka the build, I would just leave it as is. The .gemspec is published to other gems. Just put it back and make sure the build passes for all these combinations.
There was a problem hiding this comment.
If I add it to the Gemfile, does that also make it a dependency for the entire project? Or does just the .gemspec determine that when not compiling the project locally?
There was a problem hiding this comment.
I've actually answered my own question here after reading up on it, I'll update the PR
aschuster3 force-pushed the remove-grape-dependencies branch from 8857d38 to 964771c Compare | This is great, merging. |
2 participants
While this gem was constructed with
grapeandgrape-swaggerin mind, they are technically not necessary for non-test purposes. This will address this issue.