Skip to content

Conversation

@nevinera
Copy link
Contributor

Add a spec checking that the supplied options are correctly parsed from the html element's data attribute.

it 'evaluates config options correctly' do
visit '/swagger'
page_options_json = page.evaluate_script("$('html').data('swagger-options')").to_json
warn page.body
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the warn statements?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I get trying to pr from my phone.

@dblock
Copy link
Member

dblock commented Jul 12, 2016

I'll take it!

@dblock dblock merged commit 31a0173 into ruby-grape:master Jul 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants